Thread (85 messages) 85 messages, 5 authors, 2014-05-26

Re: [PATCH 22/51] Input: atmel_mxt_ts - Add shutdown function

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2013-07-10 16:55:16
Also in: lkml

On Mon, Jul 08, 2013 at 10:56:06AM +0100, Nick Dyer wrote:
Dmitry Torokhov wrote:
quoted
On Thu, Jun 27, 2013 at 01:48:57PM +0100, Nick Dyer wrote:
quoted
Signed-off-by: Nick Dyer <redacted>
Acked-by: Benson Leung <bleung@chromium.org>
Why is this needed?
The patch disables the interrupt handler on shutdown.

One of our customers reported a bug caused by input events being generated
during shutdown (for example if the user was touching the device whilst it
was turning off), which was solved by putting in this change.
What kind of bug? Could you please be more precise?
However, now you've drawn my attention to it again, it seems to me that
probably a better thing for us to be doing would be to power off the
touchscreen controller here, and let the interrupt disable be handled by
core code - do you agree?
We'd be powering off everything in a moment anyway, no? Or is there a
concern that the device will stay powered up even if the system is in off
state?

Thanks.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help