Thread (11 messages) 11 messages, 3 authors, 2013-08-20

Re: [PATCH v2 1/2] input: document gamepad API and add extra keycodes

From: Jiri Kosina <hidden>
Date: 2013-06-27 09:47:51
Also in: lkml

On Wed, 26 Jun 2013, Dmitry Torokhov wrote:
On Sat, Jun 15, 2013 at 03:32:44PM +0200, David Herrmann wrote:
quoted
--- a/include/uapi/linux/input.h
+++ b/include/uapi/linux/input.h
@@ -507,10 +507,14 @@ struct input_keymap_entry {
 
 #define BTN_GAMEPAD		0x130
 #define BTN_A			0x130
+#define BTN_SOUTH		0x130
Could we do:

#define BTN_SOUTH		0x130
#define BTN_A			BTN_SOUTH

so that it is clear that BTN_A, BTN_B, etc are legacy definitions and
not an accidental typos that need their own key codes.
Makes sense, will do that modification.
Otherwise:

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Thanks Dmitry. Will be taking it (with the above modification) through my 
tree.

-- 
Jiri Kosina
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help