Thread (64 messages) 64 messages, 8 authors, 2013-07-04

Re: [PATCH 01/22] mfd/ti_am335x_tscadc: remove regmap

From: Mark Brown <hidden>
Date: 2013-06-14 13:54:38
Also in: linux-iio, linux-omap, lkml

On Tue, Jun 11, 2013 at 04:34:53PM +0200, Sebastian Andrzej Siewior wrote:
quoted
quoted
Therefore this patch removes regmap part of the driver.
quoted
NAK. Using regmap is better than open coding your register accesses, and
the children not using this API is not a reason for the MFD driver to do
the same.
There is no advantage over using regmap in the first place. It goes
through a few layers, uses no caching because almost all registers are
volatile and this is a direct bus. In the end it complicates more than
it helps.
It does give you tracepoints and debugfs.  If it's making things at all
complicated we need to look at why that is and figure out how to fix
that since it's probably an issue for other users.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help