Re: [PATCH 01/22] mfd/ti_am335x_tscadc: remove regmap

On 06/11/2013 04:23 PM, Samuel Ortiz wrote:

Hi Sebastian,

Hi Samuel,

quoted

Therefore this patch removes regmap part of the driver.

NAK. Using regmap is better than open coding your register accesses, and
the children not using this API is not a reason for the MFD driver to do
the same.

There is no advantage over using regmap in the first place. It goes
through a few layers, uses no caching because almost all registers are
volatile and this is a direct bus. In the end it complicates more than
it helps.

Cheers,
Samuel.

Sebastian