On Mon, 28 Jan 2013, simon@mungewell.org wrote:

quoted

quoted

I'm happy to change it; However Steelseries' other devices are all
keyboards/mice intended for/marketed at gamers. Since other Steelseries
devices are unlikely to have the same structure (OK I'm just guessing on
that) is it better to keep this driver somewhat 'seperated'?

I mean, not make life difficult trying to merge keyboard code in with
this
wheel's code.... if that is required in future.

I don't think it's strictly required, but it seems to work quite nicely
for other drivers as well.

OK I'll wait a couple of days in-case any more comments come in and re-do
the patch with the file name 'hid-steelseries.c' towards the end of the
week.

Works for me. I have finished the review and don't have any other 
comments.

Thanks,

-- 
Jiri Kosina
SUSE Labs