On Mon, 28 Jan 2013, simon@mungewell.org wrote:

quoted

quoted

quoted

From: simon <simon@simon-virtual-machine.(none)>

Add support the SRW-S1 by patching HID descriptor to read axis
as Generic Desktop X, Y and Z (rather than Usage page being
'Simulation').

Signed-off-by: Simon Wood <redacted>
tested-by: John Murphy <redacted>

Hi Simon,

thanks for the patch.

quoted

---
 drivers/hid/Kconfig     |    6 +++++
 drivers/hid/Makefile    |    1 +
 drivers/hid/hid-core.c  |    1 +
 drivers/hid/hid-ids.h   |    3 +++
 drivers/hid/hid-srws1.c |   58
+++++++++++++++++++++++++++++++++++++++++++++++

Is hid-srws1 really the best name? My understanding is that the vendor

is

quoted

called Steelseries, and we mostly stick to calling the drivers

according

quoted

to the device vendors (and grouping the quirks accordingly).

So how about hid-steelseries?

I'm happy to change it; However Steelseries' other devices are all
keyboards/mice intended for/marketed at gamers. Since other Steelseries
devices are unlikely to have the same structure (OK I'm just guessing on
that) is it better to keep this driver somewhat 'seperated'?

I mean, not make life difficult trying to merge keyboard code in with
this
wheel's code.... if that is required in future.

I don't think it's strictly required, but it seems to work quite nicely
for other drivers as well.

OK I'll wait a couple of days in-case any more comments come in and re-do
the patch with the file name 'hid-steelseries.c' towards the end of the
week.

Thanks,
Simon