Re: [PATCH v6] Cypress PS/2 Trackpad driver

On Mon, Dec 10, 2012 at 06:13:59PM +0100, Henrik Rydberg wrote:

quoted

quoted

quoted

+config MOUSE_PS2_CYPRESS
+       bool "Cypress PS/2 mouse protocol extension" if EXPERT

Why EXPERT here?

quoted

+       default y

Should it really be default y here?

This config entry (with phrases "if EXPERT" and "default y") was simply
cloned from similar devices (e.g. SYNAPTICS, ALPS, LIFEBOOK).

If your preference is that CYPRESS should be disabled by default, I'll
omit those phrases.  Please advise.

Dmitry, which default do you prefer here?

Given that psmouse is monolithic and can't be [easily] split into
separate drivers (because they each protocol has to be actively probed),
I believe that allprotocols should be enabled by default. People who
really know what they are doing can reduce the size by compiling parts
of it out.

So copying what other protocols did was right ;)

Thanks.

-- 
Dmitry