Re: [PATCH v6] Cypress PS/2 Trackpad driver

From
Kamal Mostafa <hidden>
Date
2012-12-08 17:03:45
Also in
lkml
Reply to
Henrik Rydberg, 2012-12-08
Hi Henrik-

On Sat, 2012-12-08 at 13:54 +0100, Henrik Rydberg wrote:
 [...]
quoted
--- a/drivers/input/mouse/Kconfig
+++ b/drivers/input/mouse/Kconfig
@@ -68,6 +68,16 @@ config MOUSE_PS2_SYNAPTICS
 
 	  If unsure, say Y.
 
+config MOUSE_PS2_CYPRESS
+       bool "Cypress PS/2 mouse protocol extension" if EXPERT
Why EXPERT here?
quoted
+       default y
Should it really be default y here?

This config entry (with phrases "if EXPERT" and "default y") was simply
cloned from similar devices (e.g. SYNAPTICS, ALPS, LIFEBOOK).

If your preference is that CYPRESS should be disabled by default, I'll
omit those phrases.  Please advise.

quoted
+			case 0:	return(4);
No parenthesis on return.

I'll fix that.

    Reviewed-by: Henrik Rydberg [off-list ref]

Thanks!

 -Kamal

Thread (6 messages) 6 messages, 4 authors, last reply 2012-12-10
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help