Re: [PATCH v5 2/3] input: Cypress PS/2 Trackpad psmouse driver

On Thu, 2012-12-06 at 00:08 -0800, Dmitry Torokhov wrote:

[...]

Hi Dmitry-

Thanks again for your review.  The forthcoming PATCH v6 addresses all of
your requests, except for:

quoted

+	__set_bit(INPUT_PROP_BUTTONPAD, input->propbit);

I do not think it should be marked INPUT_PROP_BUTTONPAD if it has
physical buttons...

This device (my particular Cypress Trackpad unit anyway) does not have
physical buttons.  The pad is clickable; I think it is a standard
"buttonpad" device.



And just FYI, this issue has been addressed but to answer your question:

quoted

+
+	if (cytp->mode & CYTP_BIT_ABS_MASK) {

It can't be anything else, can it?

It can: in the case when the mode hasn't been set at all yet (during
detect and reconnect).  I cleaned up the logic of this routine
(cypress_validate_byte) and added explanatory comments.


 -Kamal