Re: [PATCH v3 05/13] HID: hid-multitouch: support arrays for the split of the touches in a report
From: Henrik Rydberg <hidden>
Date: 2012-11-13 15:37:41
Also in:
lkml
On Wed, Nov 07, 2012 at 05:37:28PM +0100, Benjamin Tissoires wrote:
quoted hunk ↗ jump to hunk
Win8 certification introduced the ability to transmit two X and two Y per touch. The specification precises that it must be used in an array. This test guarantees that we split the touches on the last element in this array. Signed-off-by: Benjamin Tissoires <redacted> --- drivers/hid/hid-multitouch.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 9f64e36..a6a4e0a 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c@@ -577,12 +577,15 @@ static int mt_event(struct hid_device *hid, struct hid_field *field, return 0; } - if (usage->hid == td->last_slot_field) - mt_complete_slot(td, field->hidinput->input); - - if (field->index == td->last_field_index - && td->num_received >= td->num_expected) - mt_sync_frame(td, field->hidinput->input); + if (usage->usage_index + 1 == field->report_count) { + /* we only take into account the last report. */ + if (usage->hid == td->last_slot_field) + mt_complete_slot(td, field->hidinput->input); + + if (field->index == td->last_field_index + && td->num_received >= td->num_expected) + mt_sync_frame(td, field->hidinput->input); + } }-- 1.7.11.7
Reviewed-by: Henrik Rydberg [off-list ref]
Thanks,
Henrik