Re: [PATCH v3 00/13] Win 8 support for digitizers
From: Benjamin Tissoires <hidden>
Date: 2012-11-13 08:12:04
Also in:
lkml
Hi Jiri, On Tue, Nov 13, 2012 at 8:47 AM, Jiri Kosina [off-list ref] wrote:
On Wed, 7 Nov 2012, Benjamin Tissoires wrote:quoted
Hi Guys, here is the third version of this patchset. I think I included most of Henrik's comments. Happy reviewing :) Cheers, Benjamin v1 introduction: So, this is an update for supporting Win 8 multitouch devices in the kernel. As I wanted to reliably forward the resolution, I noticed a bug in the processing of the unit_exponent in the hid core layer. Thus the fixes for hid-core and hid-input. v2 changes: * added missing initial patch that prevents the series to be applied on top of Jiri's tree * update to include latest hid changes * taken into account Alan's patch: "hid: put the case in the right switch statement" v3 changes: * splitted "round return value of hidinput_calc_abs_res" in a separate patch * export snto32 in hid.h as we need to use it in hid-input.c * didn't change all drivers, but add a field in hid_usage instead * add quirk MT_QUIRK_IGNORE_DUPLICATES so that any device can rely on it * easier understandable support of hovering devices * changed scan time definition * applied new definition of scan time in hid-multitouch * some other few things.Benjamin, thanks for the patchset. I am fine with the HID-specific changes (and I have sent out my Acks to the invidivual patches).
Thanks :)
For hid-multitouch changes, I'd like to have Reviewed-by: from Henrik as well. Henrik, are you planning to review this patchset, please? Also the note from Dmitry on turning ABS_SCAN_TIME into EV_MSC/MSC_TIMESTAMP should be addressed.
Yes, sure. I'll do it today.
Once this is finalized, I'd like to queue this for 3.8 in my tree.
Thanks, Benjamin
Thanks, -- Jiri Kosina SUSE Labs