Re: [PATCH 1/3] input: spear-keyboard: Use devm_*() routines

On Fri, Nov 09, 2012 at 08:06:29AM +0530, Viresh Kumar wrote:

On 8 November 2012 22:08, Dmitry Torokhov [off-list ref] wrote:

quoted

On Thu, Nov 08, 2012 at 07:10:47PM +0530, Viresh Kumar wrote:
It also breaks the error unwinding/removal of the driver as it frees
input device while IRQ handler is still active.

I have heard of this argument before, probably from you. :)
Just need clarification again. How will we get an interrupt when the controller
is stopped, unless we have a shared irq.

My bad, I missed that spear-keyboard driver implements open() and
close() methods and shuts off the device properly. Still, thanks for
switching everything to devm_*, I think it is much cleaner this way as
opposed to mixing managed and unmanaged resources.

Thanks.

-- 
Dmitry