Re: [PATCH 2/2] input: gpio-keys: Add runtime support
From: Shubhrajyoti Datta <hidden>
Date: 2012-10-11 14:22:14
Also in:
linux-arm-kernel, lkml
On Thu, Oct 11, 2012 at 7:45 PM, Lee Jones [off-list ref] wrote:
From: Jonas Aaberg <redacted>
Some change logs would have helped.
quoted hunk ↗ jump to hunk
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: linux-input@vger.kernel.org Acked-by: Lee Jones <redacted> Signed-off-by: Jonas Aaberg <redacted> Signed-off-by: Philippe Langlais <redacted> Reviewed-by: Bengt Jonsson <redacted> --- drivers/input/keyboard/gpio_keys.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c index 7947315..78de557 100644 --- a/drivers/input/keyboard/gpio_keys.c +++ b/drivers/input/keyboard/gpio_keys.c@@ -29,6 +29,7 @@ #include <linux/of_platform.h> #include <linux/of_gpio.h> #include <linux/spinlock.h> +#include <linux/pm_runtime.h> struct gpio_button_data { const struct gpio_keys_button *button;@@ -526,6 +527,7 @@ static int gpio_keys_open(struct input_dev *input) { struct gpio_keys_drvdata *ddata = input_get_drvdata(input); + pm_runtime_get_sync(input->dev.parent);
I am not an expert of the runtime. However would be grateful if you explain me what it actually do. Also I did not see any runtime suspend/ resume handlers populated.