Re: [PATCH 2/2] input: gpio-keys: Add runtime support
From: Lee Jones <hidden>
Date: 2012-10-25 07:57:19
Also in:
linux-arm-kernel, lkml
From: Lee Jones <hidden>
Date: 2012-10-25 07:57:19
Also in:
linux-arm-kernel, lkml
On Fri, 12 Oct 2012, Linus Walleij wrote:
On Thu, Oct 11, 2012 at 4:22 PM, Shubhrajyoti Datta [off-list ref] wrote:quoted
quoted
@@ -526,6 +527,7 @@ static int gpio_keys_open(struct input_dev *input) { struct gpio_keys_drvdata *ddata = input_get_drvdata(input); + pm_runtime_get_sync(input->dev.parent);I am not an expert of the runtime. However would be grateful if you explain me what it actually do.This increase the reference count of the runtime status container for the device. _sync makes sure it happens now. Consult: Documentation/power/runtime_pm.txtquoted
Also I did not see any runtime suspend/ resume handlers populated.It is not necessary to handle the power state at the driver level, it can just as well be handled by the voltage/power domain, or at the class, type or bus level. But the individual driver has to notify the system upward if it needs to be powered on or when it may or must be relaxed. Yours, Linus Walleij
Friendly poke. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog