Re: [Patch v1 4/7] DA9055 GPIO driver

From
Mark Brown <hidden>
Date
2012-09-14 16:38:57
Reply to
Linus Walleij, 2012-09-14
On Fri, Sep 14, 2012 at 04:13:57PM +0200, Linus Walleij wrote:
But the parent driver is using regmap, sand you seem not to use the
struct da9055
for anything else than passing reads/writes, so isn't it simpler to just pass
the struct regmap * and use update_bits etc directly and remove a layer of
indirection?
I'm very uncertain but Mark will know the proper design pattern.
Either way is fine - usually the device specific functions end up being
static inlines in the header so the code is the same.  It really depends
if it's useful to have the full device pointer around for other things.
Thread (6 messages) 6 messages, 4 authors, last reply 2012-10-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help