Re: [Patch v1 4/7] DA9055 GPIO driver
flat view
From: Laxman Dewangan <ldewangan@nvidia.com>
Date: 2012-09-14 13:33:12
On Friday 14 September 2012 07:00 PM, Ashish Jangam wrote:
This is the GPIO patch for the DA9055 PMIC. This patch has got dependency on the DA9055 MFD core. This patch is functionally tested on SMDK6410 board. Signed-off-by: David Dajun Chen<redacted> Signed-off-by: Ashish Jangam<redacted> ---
quoted hunk ↗ jump to hunk
+struct da9055_gpio { + struct da9055 *da9055; + struct gpio_chip gp;
I suggest to make gp as first member so that offset of member will be 0 in container_of macro and avoid one ops.
+static struct gpio_chip reference_gp __devinitdata = {This is device int data and you used after device initailisation. I think this can create issue. ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. -----------------------------------------------------------------------------------