Thread (5 messages) 5 messages, 3 authors, 2012-06-07

Re: [PATCH] drivers/input/mouse: Fix a "make randconfig" warning at MOUSE_APPLETOUCH dependency with USB_SUPPORT and USB_ARCH_HAS_HCD

From: devendra.aaru <hidden>
Date: 2012-06-05 10:25:31

Hi Jiri,

Thanks for the review.

On Tue, Jun 5, 2012 at 3:11 PM, Jiri Kosina [off-list ref] wrote:
quoted
diff --git a/drivers/input/mouse/Kconfig b/drivers/input/mouse/Kconfig
index cd6268c..044378f 100644
--- a/drivers/input/mouse/Kconfig
+++ b/drivers/input/mouse/Kconfig
@@ -152,7 +152,7 @@ config MOUSE_SERIAL
 config MOUSE_APPLETOUCH
      tristate "Apple USB Touchpad support"
      depends on USB_ARCH_HAS_HCD
-     select USB
+     select USB if USB_SUPPORT && USB_ARCH_HAS_HCD
Depending on USB_ARCH_HAS_HCD and then having it as a part of 'if'
condition seems odd.
So,
+    depends on USB_SUPPORT && USB_ARCH_HAS_HCD
will be good ?
Thanks,

--
Jiri Kosina
SUSE Labs
Thanks,
Devendra.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help