[PATCH] drivers/input/mouse: Fix a "make randconfig" warning at MOUSE_APPLETOUCH dependency with USB_SUPPORT and USB_ARCH_HAS_HCD

From: Devendra Naga <devendra@devendra.(none)>

when ran make randconfig got the warning

"MOUSE_APPLETOUCH selects USB which has unmet direct dependencies (USB_SUPPORT && USB_ARCH_HAS_HCD)"

Signed-off-by: Devendra Naga <redacted>
---
 drivers/input/mouse/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/mouse/Kconfig b/drivers/input/mouse/Kconfig
index cd6268c..044378f 100644
--- a/drivers/input/mouse/Kconfig
+++ b/drivers/input/mouse/Kconfig

@@ -152,7 +152,7 @@ config MOUSE_SERIAL
 config MOUSE_APPLETOUCH
 	tristate "Apple USB Touchpad support"
 	depends on USB_ARCH_HAS_HCD
-	select USB
+	select USB if USB_SUPPORT && USB_ARCH_HAS_HCD
 	help
 	  Say Y here if you want to use an Apple USB Touchpad.
 

-- 
1.7.9.5

On Tue, 15 May 2012, Devendra Naga wrote:

Depending on USB_ARCH_HAS_HCD and then having it as a part of 'if' 
condition seems odd.

Thanks,

-- 
Jiri Kosina
SUSE Labs

Hi Jiri,

Thanks for the review.

On Tue, Jun 5, 2012 at 3:11 PM, Jiri Kosina [off-list ref] wrote:

quoted

diff --git a/drivers/input/mouse/Kconfig b/drivers/input/mouse/Kconfig
index cd6268c..044378f 100644
--- a/drivers/input/mouse/Kconfig
+++ b/drivers/input/mouse/Kconfig

@@ -152,7 +152,7 @@ config MOUSE_SERIAL

 config MOUSE_APPLETOUCH
      tristate "Apple USB Touchpad support"
      depends on USB_ARCH_HAS_HCD
-     select USB
+     select USB if USB_SUPPORT && USB_ARCH_HAS_HCD

Depending on USB_ARCH_HAS_HCD and then having it as a part of 'if'
condition seems odd.

So,
+    depends on USB_SUPPORT && USB_ARCH_HAS_HCD
will be good ?

Thanks,

--
Jiri Kosina
SUSE Labs

Thanks,
Devendra.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On Tuesday, June 05, 2012 03:55:31 PM devendra.aaru wrote:

Hi Jiri,

Thanks for the review.

On Tue, Jun 5, 2012 at 3:11 PM, Jiri Kosina [off-list ref] wrote:

quoted

quoted

diff --git a/drivers/input/mouse/Kconfig b/drivers/input/mouse/Kconfig
index cd6268c..044378f 100644
--- a/drivers/input/mouse/Kconfig
+++ b/drivers/input/mouse/Kconfig

@@ -152,7 +152,7 @@ config MOUSE_SERIAL
 config MOUSE_APPLETOUCH
      tristate "Apple USB Touchpad support"
      depends on USB_ARCH_HAS_HCD
-     select USB
+     select USB if USB_SUPPORT && USB_ARCH_HAS_HCD

Depending on USB_ARCH_HAS_HCD and then having it as a part of 'if'
condition seems odd.

So,
+    depends on USB_SUPPORT && USB_ARCH_HAS_HCD
will be good ?

I'd rather we "select"ed the new symbol. So please do

	depends on USB_ARCH_HAS_HCD
	select USB
+	select USB_SUPPORT
	
Thanks.


-- 
Dmitry

Hello Dimitry,

On Wed, Jun 6, 2012 at 12:50 AM, Dmitry Torokhov
[off-list ref] wrote:

I'd rather we "select"ed the new symbol. So please do

       depends on USB_ARCH_HAS_HCD
       select USB
+       select USB_SUPPORT

Thanks.


--

with your change told, i ran make and got the following error when compiling it.

devendra@devendra:~/linux$ make
scripts/kconfig/conf --silentoldconfig Kconfig
drivers/usb/Kconfig:76:error: recursive dependency detected!
drivers/usb/Kconfig:76:	symbol USB_ARCH_HAS_HCD depends on USB_SUPPORT
drivers/usb/Kconfig:58:	symbol USB_SUPPORT is selected by MOUSE_APPLETOUCH
drivers/input/mouse/Kconfig:152:	symbol MOUSE_APPLETOUCH depends on
USB_ARCH_HAS_HCD

It seems that USB_ARCH_HAS_HCD needs to be selected? too.

Dmitry

may i attach .config?

Thanks,
Devendra
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html