Re: [PATCH] TWL6040: fix build error
From: Peter Ujfalusi <hidden>
Date: 2012-05-11 12:24:24
Also in:
lkml
On 05/11/2012 07:27 AM, Grant Likely wrote:
On Thu, May 10, 2012 at 4:49 PM, Paul Gortmaker [off-list ref] wrote:quoted
On Thu, May 10, 2012 at 2:44 PM, Sasha Levin [off-list ref] wrote:quoted
Fixes build error due to missing of_property_read_u32.Yes, I saw the same on x86-64 allyesconfig -- which means that in addition to this missing header, it needs to have a Kconfig dependency that limits it to just being enabled on the platforms where it physically is possible to have the hardware. I'm guessing limiting to ARM would be a good start?IIRC, this hardware is available on x86. Also, if CONFIG_OF is not set, then the of_property_read_* functions compile out to do-nothing stubs.
I had only linux/of_device.h included which would include of.h only if CONFIG_OF_DEVICE is set. Since the i386 did not had OF_DEVICE the of.h was not included (by of_device.h) thus caused a build breakage. -- Péter -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html