Re: [PATCH] TWL6040: fix build error

On Fri, May 11, 2012 at 10:03:51AM +0300, Peter Ujfalusi wrote:

Hi,

On 05/11/2012 01:49 AM, Paul Gortmaker wrote:

quoted

On Thu, May 10, 2012 at 2:44 PM, Sasha Levin [off-list ref] wrote:

quoted

Fixes build error due to missing of_property_read_u32.

Yes, I saw the same on x86-64 allyesconfig -- which means that in addition to
this missing header, it needs to have a Kconfig dependency that limits
it to just being enabled on the platforms where it physically is possible to
have the hardware.  I'm guessing limiting to ARM would be a good start?

Yes it is only usable on ARM, most specifically on OMAP4+ platforms.
If I make the twl6040 MFD core to depend on ARM (or even on OMAP) this
won't happen again.

Is there any other errors beside missing include of.h (and extra
of_device.h?). The driver seems to be compiling fine on x86_64 so no
need to limit to ARM only...

Thanks.

-- 
Dmitry