Re: [PATCH 11/16 v2] Input: atmel_mxt_ts - refactor reading object table
From: Henrik Rydberg <hidden>
Date: 2012-04-13 09:32:12
Also in:
lkml
From: Henrik Rydberg <hidden>
Date: 2012-04-13 09:32:12
Also in:
lkml
quoted
Putting this conversion in a function would be nice, it would also make it clear that the inverse, used for writing, is currently missing. Alternatively, how about making the object struct actually match the read data? To top it off, one could introduce a collection, prepending the buffer size, making the write operation trivial.AFAIK, there is no corresponding "object table" write. The "object table" (maybe more aptly named the "object descriptor table") is an immutable blob read from firmware that describes some actual data objects elsewhere in device memory. It is those actual objects that are writable. When they are written, it is the actual size, location and number of instances (not their raw '-1' values) that is useful.
I am talking about the data that is being read here and written in mxt_check_reg_init(). By matching the struct with that data, all the copies you make would go away. Henrik