Re: [PATCH 15/16 v2] Input: atmel_mxt_ts - send all MT-B slots in one input report
From: Henrik Rydberg <hidden>
Date: 2012-04-13 09:17:41
Also in:
lkml
Hi Daniel,
quoted hunk ↗ jump to hunk
Each interrupt contains information for all contacts with changing properties. Process all of this information at once, and send it all in a a single input report (ie input events ending in EV_SYN/SYN_REPORT). This patch was tested using an MXT224E. Signed-off-by: Daniel Kurtz <redacted> --- drivers/input/touchscreen/atmel_mxt_ts.c | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-)diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index be1e2ec..d8b23ad 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c@@ -532,9 +532,6 @@ static void mxt_input_touch(struct mxt_data *data, struct mxt_message *message) input_report_abs(input_dev, ABS_MT_TOUCH_MAJOR, area); /* TODO: Use vector to report ORIENTATION & TOUCH_MINOR */ } - - input_mt_report_pointer_emulation(input_dev, false); - input_sync(input_dev); } static irqreturn_t mxt_interrupt(int irq, void *dev_id)@@ -542,7 +539,9 @@ static irqreturn_t mxt_interrupt(int irq, void *dev_id) struct mxt_data *data = dev_id; struct mxt_message message; struct device *dev = &data->client->dev; + bool update_input; + update_input = false; do { if (mxt_read_message(data, &message)) { dev_err(dev, "Failed to read message\n");@@ -552,11 +551,17 @@ static irqreturn_t mxt_interrupt(int irq, void *dev_id) if (message.reportid >= data->T9_reportid_min && message.reportid <= data->T9_reportid_max) { mxt_input_touch(data, &message); + update_input = true; } else { mxt_dump_message(dev, &message); } } while (message.reportid != 0xff); + if (update_input) { + input_mt_report_pointer_emulation(data->input_dev, false); + input_sync(data->input_dev); + } +
Strictly speaking, the update_input variable is not needed either, although it will save some cycles. The input core will omit the sync when there is nothing to report.
end: return IRQ_HANDLED; } -- 1.7.7.3
Thanks, Henrik