Re: [PATCH 1/1] HID: add have_special_driver hid module parameter

On Mon, 27 Feb 2012, Nikolai Kondrashov wrote:

quoted

Add "have_special_driver" hid module parameter - a list of additional 
HID devices which have specialized driver on HID bus. Needed to 
support out-of-tree HID drivers.

Did you have time to take a look at the patch?
If there's anything wrong with it, please tell me and I'll fix it.

Hi Nikolai,

well, I am not really sure what value does it provide to have such 
functionality in the kernel.

I can understand that it helps you when developing out-of-tree (yet) 
drivers ... but as you are patching the kernel anyway with those drivers, 
you can easily run a kernel that has hid_have_special_driver[] array 
adjusted accordingly. And once you are submitting the driver for 
inclusion, you are of course submitting it together with 
hid_have_special_driver[] addition.

So it doesn't seem to be a debugging facility to me, and neither does it 
provide any added value for users of vanilla kernel.

Hmm?

Thanks,

-- 
Jiri Kosina
SUSE Labs