Re: [PATCH 3/3] HID: usbhid: defer LED setting to a workqueue

Am Mittwoch, 14. Dezember 2011, 09:19:31 schrieb Daniel Kurtz:

On Wed, Dec 14, 2011 at 4:01 PM, Oliver Neukum [off-list ref] wrote:

quoted

Am Donnerstag, 17. November 2011, 12:23:50 schrieb Daniel Kurtz:

quoted

Defer LED setting action to a workqueue.
This is more likely to send all LED change events in a single URB.

Hi,

I hope I am looking at the correct version of this patch.

Yes, that is the correct version.  It looks like I forgot to bump r in
the [PATCH] of the subject.

quoted

But as far as I can see the work for handling LEDs is not delayed
while a reset is going on. That is wrong.

Good catch, I think.  Your comment is a bit terse, so it is difficult to
tell exactly what you are recommending.  Perhaps something like the following?

The problem done this way is what submits the work again after
it did nothing because a reset was pending.

	Regards
		Oliver