Re: [PATCH 0/3 v2] usb/hid-core: drain URB queue when going to suspend

On Wed, 7 Dec 2011, Daniel Kurtz wrote:

quoted

In some situations, trying to suspend a laptop with an attached USB keyboard
would fail if both NumLock and CapsLock LEDs were lit.
This was due to a race condition between asynchronously submitted
LED-manipulating CTRL URBs and the suspend process.

This is a different solution to the same problem highlighted here:
https://lkml.org/lkml/2011/9/2/391

These patches are against Jiri's hid/for-next branch.

Daniel Kurtz (3):
 HID: usbhid: remove LED_ON
 HID: usbhid: hid-core: submit queued urbs before suspend
 HID: usbhid: defer LED setting to a workqueue

Differences since v1:
 * Rebase on hid/for-next
 * Solve race with usbhid_stop() [reported by Oliver Neukum]

Hi Jiri,

Any chance you can take a look at this patch set?

Hi Dan,

it's still in my queue, sorry for delay; it absolutely hasn't been lost, I 
just haven't gotten to it yet.

Oliver, did you have a chance to review it, please? I'd apprecite your 
eventual Ack on this.

Thanks,

-- 
Jiri Kosina
SUSE Labs