Re: [PATCH] HID: hid-multitouch - add another eGalax id

On Sun, Nov 13, 2011 at 21:31, Jiri Kosina [off-list ref] wrote:

On Sat, 12 Nov 2011, Benjamin Tissoires wrote:

quoted

quoted

From: Chris Bagwell <redacted>

This allows ASUS Eee Slate touchscreens to work.

Signed-off-by: Chris Bagwell <redacted>
---

I do not have one of these to test the patch but I helped a user
debug why his new touchscreen was being treated as a touchpad.
He reported success after adding this ID.

The patch looks good.
Reviewed-by: Benjamin Tissoires <redacted>

Applied, thanks.

quoted

quoted

I'm sending this since I'm unsure status of patch to auto-assign
multitouch devices to hid-multitouch. That would probably have
solved issue as well.

Well, as of today, the auto-detection is partly included in 3.2-rc1:
the generic hid layer will release the device (ie, it's not needed
anymore to patch hid-core.c while adding a multitouch device to its
list), but hid-multitouch is not capable of handling it after the
release of the generic part.
BTW, egalax devices need a special handling, and we may have to add
them one by one.

Alternatively, we could use:
 +       {  .driver_data = MT_CLS_EGALAX,
 +               HID_USB_DEVICE(USB_VENDOR_ID_DWAV, HID_ANY_ID) },
but that's hoping that DWAV won't do any other things than multitouch panels.
Jiri, have you an idea on this?

Currently we have something like 7 entries, which doesn't sound that bad.
If the number of device IDs starts to grow rapidly, we should start
thinking about this, but I think we are not there yet.

Hi Jiri,

as you can see, on
http://lii-enac.fr/en/architecture/linux-input/multitouch-devices.html
we currently have 13 different PID for egalax.... But we currently
support 7 (we missed some users and tests/feedback).

If it's good for you to have PID added one by one, I'm fine with that.

Cheers,
Benjamin

PS: sorry for the previous miss sent mail, I clicked on send too early ;-)
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html