[PATCH] HID: hid-multitouch - add another eGalax id

Subsystems: hid core layer, the rest

STALE5374d

8 messages, 4 authors, 2011-11-14 · open the first message on its own page

[PATCH] HID: hid-multitouch - add another eGalax id

From: <hidden>
Date: 2011-11-11 20:21:28

From: Chris Bagwell <redacted>

This allows ASUS Eee Slate touchscreens to work.

Signed-off-by: Chris Bagwell <redacted>
---

I do not have one of these to test the patch but I helped a user
debug why his new touchscreen was being treated as a touchpad.
He reported success after adding this ID.

I'm sending this since I'm unsure status of patch to auto-assign
multitouch devices to hid-multitouch. That would probably have
solved issue as well.

 drivers/hid/hid-core.c       |    1 +
 drivers/hid/hid-ids.h        |    1 +
 drivers/hid/hid-multitouch.c |    3 +++
 3 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 848a56c..f973d33 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1409,6 +1409,7 @@ static const struct hid_device_id hid_have_special_driver[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_DWAV, USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH2) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_DWAV, USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH3) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_DWAV, USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH4) },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_DWAV, USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH5) },
 	{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_ELECOM, USB_DEVICE_ID_ELECOM_BM084) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_ELO, USB_DEVICE_ID_ELO_TS2515) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_EMS, USB_DEVICE_ID_EMS_TRIO_LINKER_PLUS_II) },
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 06ce996..7bb5227 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -235,6 +235,7 @@
 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH2	0x72a1
 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH3	0x480e
 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH4	0x726b
+#define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH5	0xa001
 
 #define USB_VENDOR_ID_ELECOM		0x056e
 #define USB_DEVICE_ID_ELECOM_BM084	0x0061
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index f1c909f..a59d939 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -662,6 +662,9 @@ static const struct hid_device_id mt_devices[] = {
 	{  .driver_data = MT_CLS_EGALAX,
 		HID_USB_DEVICE(USB_VENDOR_ID_DWAV,
 			USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH4) },
+	{  .driver_data = MT_CLS_EGALAX,
+		HID_USB_DEVICE(USB_VENDOR_ID_DWAV,
+			USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH5) },
 
 	/* Elo TouchSystems IntelliTouch Plus panel */
 	{ .driver_data = MT_CLS_DUAL_NSMU_CONTACTID,
-- 
1.7.7

Re: [PATCH] HID: hid-multitouch - add another eGalax id

From: Benjamin Tissoires <hidden>
Date: 2011-11-12 15:01:14

Hi Chris,

On Fri, Nov 11, 2011 at 21:21,  [off-list ref] wrote:
From: Chris Bagwell <redacted>

This allows ASUS Eee Slate touchscreens to work.

Signed-off-by: Chris Bagwell <redacted>
---

I do not have one of these to test the patch but I helped a user
debug why his new touchscreen was being treated as a touchpad.
He reported success after adding this ID.
The patch looks good.
Reviewed-by: Benjamin Tissoires <redacted>
I'm sending this since I'm unsure status of patch to auto-assign
multitouch devices to hid-multitouch. That would probably have
solved issue as well.
Well, as of today, the auto-detection is partly included in 3.2-rc1:
the generic hid layer will release the device (ie, it's not needed
anymore to patch hid-core.c while adding a multitouch device to its
list), but hid-multitouch is not capable of handling it after the
release of the generic part.
BTW, egalax devices need a special handling, and we may have to add
them one by one.

Alternatively, we could use:
 +       {  .driver_data = MT_CLS_EGALAX,
 +               HID_USB_DEVICE(USB_VENDOR_ID_DWAV, HID_ANY_ID) },
but that's hoping that DWAV won't do any other things than multitouch panels.
Jiri, have you an idea on this?

Cheers,
Benjamin
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: hid-multitouch - add another eGalax id

From: Jiri Kosina <hidden>
Date: 2011-11-13 20:31:08

On Sat, 12 Nov 2011, Benjamin Tissoires wrote:
quoted
From: Chris Bagwell <redacted>

This allows ASUS Eee Slate touchscreens to work.

Signed-off-by: Chris Bagwell <redacted>
---

I do not have one of these to test the patch but I helped a user
debug why his new touchscreen was being treated as a touchpad.
He reported success after adding this ID.
The patch looks good.
Reviewed-by: Benjamin Tissoires <redacted>
Applied, thanks.
quoted
I'm sending this since I'm unsure status of patch to auto-assign
multitouch devices to hid-multitouch. That would probably have
solved issue as well.
Well, as of today, the auto-detection is partly included in 3.2-rc1:
the generic hid layer will release the device (ie, it's not needed
anymore to patch hid-core.c while adding a multitouch device to its
list), but hid-multitouch is not capable of handling it after the
release of the generic part.
BTW, egalax devices need a special handling, and we may have to add
them one by one.

Alternatively, we could use:
 +       {  .driver_data = MT_CLS_EGALAX,
 +               HID_USB_DEVICE(USB_VENDOR_ID_DWAV, HID_ANY_ID) },
but that's hoping that DWAV won't do any other things than multitouch panels.
Jiri, have you an idea on this?
Currently we have something like 7 entries, which doesn't sound that bad. 
If the number of device IDs starts to grow rapidly, we should start 
thinking about this, but I think we are not there yet.

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: hid-multitouch - add another eGalax id

From: Benjamin Tissoires <hidden>
Date: 2011-11-13 21:59:42

On Sun, Nov 13, 2011 at 21:31, Jiri Kosina [off-list ref] wrote:
On Sat, 12 Nov 2011, Benjamin Tissoires wrote:
quoted
quoted
From: Chris Bagwell <redacted>

This allows ASUS Eee Slate touchscreens to work.

Signed-off-by: Chris Bagwell <redacted>
---

I do not have one of these to test the patch but I helped a user
debug why his new touchscreen was being treated as a touchpad.
He reported success after adding this ID.
The patch looks good.
Reviewed-by: Benjamin Tissoires <redacted>
Applied, thanks.
quoted
quoted
I'm sending this since I'm unsure status of patch to auto-assign
multitouch devices to hid-multitouch. That would probably have
solved issue as well.
Well, as of today, the auto-detection is partly included in 3.2-rc1:
the generic hid layer will release the device (ie, it's not needed
anymore to patch hid-core.c while adding a multitouch device to its
list), but hid-multitouch is not capable of handling it after the
release of the generic part.
BTW, egalax devices need a special handling, and we may have to add
them one by one.

Alternatively, we could use:
 +       {  .driver_data = MT_CLS_EGALAX,
 +               HID_USB_DEVICE(USB_VENDOR_ID_DWAV, HID_ANY_ID) },
but that's hoping that DWAV won't do any other things than multitouch panels.
Jiri, have you an idea on this?
Currently we have something like 7 entries, which doesn't sound that bad.
If the number of device IDs starts to grow rapidly, we should start
thinking about this, but I think we are not there yet.

Thanks,

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: hid-multitouch - add another eGalax id

From: Benjamin Tissoires <hidden>
Date: 2011-11-13 22:03:24

On Sun, Nov 13, 2011 at 21:31, Jiri Kosina [off-list ref] wrote:
On Sat, 12 Nov 2011, Benjamin Tissoires wrote:
quoted
quoted
From: Chris Bagwell <redacted>

This allows ASUS Eee Slate touchscreens to work.

Signed-off-by: Chris Bagwell <redacted>
---

I do not have one of these to test the patch but I helped a user
debug why his new touchscreen was being treated as a touchpad.
He reported success after adding this ID.
The patch looks good.
Reviewed-by: Benjamin Tissoires <redacted>
Applied, thanks.
quoted
quoted
I'm sending this since I'm unsure status of patch to auto-assign
multitouch devices to hid-multitouch. That would probably have
solved issue as well.
Well, as of today, the auto-detection is partly included in 3.2-rc1:
the generic hid layer will release the device (ie, it's not needed
anymore to patch hid-core.c while adding a multitouch device to its
list), but hid-multitouch is not capable of handling it after the
release of the generic part.
BTW, egalax devices need a special handling, and we may have to add
them one by one.

Alternatively, we could use:
 +       {  .driver_data = MT_CLS_EGALAX,
 +               HID_USB_DEVICE(USB_VENDOR_ID_DWAV, HID_ANY_ID) },
but that's hoping that DWAV won't do any other things than multitouch panels.
Jiri, have you an idea on this?
Currently we have something like 7 entries, which doesn't sound that bad.
If the number of device IDs starts to grow rapidly, we should start
thinking about this, but I think we are not there yet.
Hi Jiri,

as you can see, on
http://lii-enac.fr/en/architecture/linux-input/multitouch-devices.html
we currently have 13 different PID for egalax.... But we currently
support 7 (we missed some users and tests/feedback).

If it's good for you to have PID added one by one, I'm fine with that.

Cheers,
Benjamin

PS: sorry for the previous miss sent mail, I clicked on send too early ;-)
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: hid-multitouch - add another eGalax id

From: Marek Vasut <hidden>
Date: 2011-11-13 23:15:34

On Sat, 12 Nov 2011, Benjamin Tissoires wrote:
quoted
quoted
From: Chris Bagwell <redacted>

This allows ASUS Eee Slate touchscreens to work.

Signed-off-by: Chris Bagwell <redacted>
---

I do not have one of these to test the patch but I helped a user
debug why his new touchscreen was being treated as a touchpad.
He reported success after adding this ID.
The patch looks good.
Reviewed-by: Benjamin Tissoires <redacted>
Applied, thanks.
quoted
quoted
I'm sending this since I'm unsure status of patch to auto-assign
multitouch devices to hid-multitouch. That would probably have
solved issue as well.
Well, as of today, the auto-detection is partly included in 3.2-rc1:
the generic hid layer will release the device (ie, it's not needed
anymore to patch hid-core.c while adding a multitouch device to its
list), but hid-multitouch is not capable of handling it after the
release of the generic part.
BTW, egalax devices need a special handling, and we may have to add
them one by one.

Alternatively, we could use:
 +       {  .driver_data = MT_CLS_EGALAX,
 +               HID_USB_DEVICE(USB_VENDOR_ID_DWAV, HID_ANY_ID) },

but that's hoping that DWAV won't do any other things than multitouch
panels. Jiri, have you an idea on this?
Currently we have something like 7 entries, which doesn't sound that bad.
If the number of device IDs starts to grow rapidly, we should start
thinking about this, but I think we are not there yet.
Well there's another one in Acer W500. But that one handles 5 simulaneous MT 
events. I submitted a patch already, but it was held because ... I dunno why 
anymore.

M

Re: [PATCH] HID: hid-multitouch - add another eGalax id

From: Jiri Kosina <hidden>
Date: 2011-11-14 08:46:18

On Mon, 14 Nov 2011, Marek Vasut wrote:
Well there's another one in Acer W500. But that one handles 5 
simulaneous MT events. I submitted a patch already, but it was held 
because ... I dunno why anymore.
Hmm, I don't recall seeing that one. Could you please resubmit? Thanks,

-- 
Jiri Kosina
SUSE Labs

Re: [PATCH] HID: hid-multitouch - add another eGalax id

From: Marek Vasut <hidden>
Date: 2011-11-14 10:43:56

On Mon, 14 Nov 2011, Marek Vasut wrote:
quoted
Well there's another one in Acer W500. But that one handles 5
simulaneous MT events. I submitted a patch already, but it was held
because ... I dunno why anymore.
Hmm, I don't recall seeing that one. Could you please resubmit? Thanks,
I'm just rebuilding 3.1.0+ kernel with the patch so I can resubmit it rebased 
against fresh kernel. There was some discussion about detecting how many 
fingers/points does the device support, so I'm also testing with that.

M
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help