Re: [PATCH V3] input: Fix USB autosuspend on bcm5974

On Tue, 11 Oct 2011, Dmitry Torokhov wrote:

On Tue, Oct 11, 2011 at 06:10:12AM +0200, Oliver Neukum wrote:

quoted

Am Dienstag, 11. Oktober 2011, 02:11:03 schrieb Matthew Garrett:

quoted

Ah, right, sorry - I wasn't trying to use the device after it had been 
closed. In an ideal world we'd really want to be able to indicate that 
we don't want a remote wakeup in that situation. Otherwise, the patch 
looks good. Thank you!

It looks like we had exactly that capability until
48826626263d4a61d06fd8c5805da31f925aefa0
removed it.

Hmm, reading Alan's comment I can see why wakeup might be beneficial
when system is in the sleep state, but while it is running and there is
no driver or driver wants to disable wakeups I think we should
accommodate it.

Currently, wakeup is enabled for USB devices during autosuspend if and
only if one or more of the interface drivers has set the
intf->needs_remote_wakeup flag.  Therefore all that usbhid should need 
to do is clear that flag when the device file is closed.

Alan Stern