On Tue, Oct 11, 2011 at 12:44:31AM +0200, Henrik Rydberg wrote:
On Mon, Oct 10, 2011 at 10:12:31PM +0100, Matthew Garrett wrote:
quoted
Is this with the patch I sent for usbhid earlier applied? Right now the
keyboard will fail to suspend after system suspend, which will keep the
entire composite device awake. I'm looking into your other issue now.
Ahh, yes, the suspend failure was due to the keyboard interface,
thanks. The loop-on-closed is still present, though (as expected,
since there is no usb_mark_last_busy() call).
Ah, right, sorry - I wasn't trying to use the device after it had been
closed. In an ideal world we'd really want to be able to indicate that
we don't want a remote wakeup in that situation. Otherwise, the patch
looks good. Thank you!
--
Matthew Garrett | mjg59@srcf.ucam.org