Re: [PATCH 3/5] drivers/hid/hid-roccat.c: eliminate a null pointer dereference
From: Dan Carpenter <hidden>
Date: 2011-10-29 06:27:42
Also in:
kernel-janitors, lkml
On Sat, Oct 29, 2011 at 01:58:15AM +0200, Julia Lawall wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/hid/hid-roccat.c b/drivers/hid/hid-roccat.c index 2596321..36a28b8 100644 --- a/drivers/hid/hid-roccat.c +++ b/drivers/hid/hid-roccat.c@@ -163,14 +163,15 @@ static int roccat_open(struct inode *inode, struct file *file) device = devices[minor]; - mutex_lock(&device->readers_lock); - if (!device) { pr_emerg("roccat device with minor %d doesn't exist\n", minor); - error = -ENODEV; - goto exit_err; + kfree(reader); + mutex_lock(&devices_lock);
Typo. mutex_unlock() instead of mutex_lock().
+ return -ENODEV;
}
+ mutex_lock(&device->readers_lock);
+
if (!device->open++) {
/* power on device on adding first reader */
error = hid_hw_power(device->hid, PM_HINT_FULLON);regards, dan carpenter