Re: [PATCH 1/2] HID: kfree() NULL pointer cleanup
From: Julia Lawall <hidden>
Date: 2011-08-04 20:48:11
Also in:
kernel-janitors, lkml
On Thu, 4 Aug 2011, Bojan Prtvar wrote:
Checking for NULL pointers before kfree() is redundant.
I would find it even nicer to just add a new lavel to skip over the kfree in the case where pm is NULL. It is statically apparent in the source code. julia
quoted hunk ↗ jump to hunk
Signed-off-by: Bojan Prtvar <redacted> --- drivers/hid/hid-prodikeys.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)diff --git a/drivers/hid/hid-prodikeys.c b/drivers/hid/hid-prodikeys.c index 158b389..62f95d4 100644 --- a/drivers/hid/hid-prodikeys.c +++ b/drivers/hid/hid-prodikeys.c@@ -849,9 +849,7 @@ static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id) err_stop: hid_hw_stop(hdev); err_free: - if (pm != NULL) - kfree(pm); - + kfree(pm); kfree(pk); return ret; }-- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html