Thread (3 messages) flat view 3 messages, 2 authors, 2011-08-04
STALE5506d

[PATCH 1/2] HID: kfree() NULL pointer cleanup

From: Bojan Prtvar <hidden>
Date: 2011-08-04 20:43:35
Also in: kernel-janitors, lkml
Subsystem: hid core layer, the rest · Maintainers: Jiri Kosina, Benjamin Tissoires, Linus Torvalds

Checking for NULL pointers before kfree() is redundant.

Signed-off-by: Bojan Prtvar <redacted>
---
 drivers/hid/hid-prodikeys.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/hid-prodikeys.c b/drivers/hid/hid-prodikeys.c
index 158b389..62f95d4 100644
--- a/drivers/hid/hid-prodikeys.c
+++ b/drivers/hid/hid-prodikeys.c
@@ -849,9 +849,7 @@ static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id)
 err_stop:
 	hid_hw_stop(hdev);
 err_free:
-	if (pm != NULL)
-		kfree(pm);
-
+	kfree(pm);
 	kfree(pk);
 	return ret;
 }
-- 
1.7.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help