Re: [PATCH 1/2] sony_ff_hid_descriptor

On Tue, 7 Jun 2011 15:32:15 +0200 (CEST)
Jiri Kosina [off-list ref] wrote:

On Wed, 1 Jun 2011, Antonio Ospite wrote:

quoted

On Mon, 23 May 2011 03:19:58 -0700
Simon Wood [off-list ref] wrote:

quoted

This patch modifies the HID descriptor to allow the reporting of
the accelerometers and gyro via a joystick axis.

I am going to test it tomorrow, but for now I notice that the
Signed-off-by is missing. Wait for the test before resending tho.

Plus, the short commit message can be improved a little bit, and the
long commit message could use the classic imperative form used in kernel
commit messages: "Modify the HID descriptor to...", but these are just
suggestions.

[...]

What was the result of your testing of the patches, please?

There has been an off-list discussion and I think Simon is going to send
the patches once again in a form which amends the HID descriptor even
when the Sixaxis is connected via Bluetooth.

I will retest and add the Tested-by on those.

Regards,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?