Re: [PATCH 1/2] sony_ff_hid_descriptor

On Wed, 1 Jun 2011, Antonio Ospite wrote:

On Mon, 23 May 2011 03:19:58 -0700
Simon Wood [off-list ref] wrote:

quoted

This patch modifies the HID descriptor to allow the reporting of
the accelerometers and gyro via a joystick axis.

I am going to test it tomorrow, but for now I notice that the
Signed-off-by is missing. Wait for the test before resending tho.

Plus, the short commit message can be improved a little bit, and the
long commit message could use the classic imperative form used in kernel
commit messages: "Modify the HID descriptor to...", but these are just
suggestions.

Same comments for patch 2/2.

Antonio,

thanks for the (valid) comments.

What was the result of your testing of the patches, please?

Simon, would you please, once Antionio adds his Tested-by:, to resend with 
proper authorship and Signed-off-by? 

Thanks,

-- 
Jiri Kosina
SUSE Labs