Re: [PATCH 3/5] Skip matrix size check

Hi Iiro,

On Fri, Feb 11, 2011 at 03:32:17PM +0200, Iiro Valkonen wrote:

Ok, I think the "matrix size check" should be really skipped
altogether. It is currently setting the CTE mode to match xline/yline
info that is in the platform data, but it does not take into account
for example the fact that we could have a key array in use too (key
array would need some x/y lines too). I think it would be best to just
rely on the config data, and make sure that the CTE mode set in there
matches the touch object (touchscreen, key array, proximity)
configuration (which are set in the config data too). Here's a patch
removing the check.

OK, this explanation totally makes sense, I will be applying the patch.

Next time please put such reasoning directly into patch's changelog so
that people looking through git history have this information readily
available. Commit changelogs should not only say what has been done (the
first line - subject - reflects that, as well as teh patch itself) but
more importantly _why_ the change has been made.

Thanks.

-- 
Dmitry