Re: [PATCH 3/5] Skip matrix size check
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2011-02-04 08:59:13
On Thu, Feb 03, 2011 at 04:04:53PM +0200, Iiro Valkonen wrote:
quoted hunk ↗ jump to hunk
Input: qt602240_ts - Skip matrix size check From: Iiro Valkonen <redacted> Skip the mxt224-specific matrix size check Signed-off-by: Iiro Valkonen <redacted> --- drivers/input/touchscreen/qt602240_ts.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)diff --git a/drivers/input/touchscreen/qt602240_ts.c b/drivers/input/touchscreen/qt602240_ts.c index 6ef8290..a88ec93 100644 --- a/drivers/input/touchscreen/qt602240_ts.c +++ b/drivers/input/touchscreen/qt602240_ts.c@@ -862,10 +862,17 @@ static int mxt_initialize(struct mxt_data *data) if (error) return error; + /* + * Skip this and trust what's on the chip, as the current check + * is not compatible with mXT1386. Revisit and fix. + */ /* Check X/Y matrix size */ + + /* error = mxt_check_matrix_size(data); if (error) return error; + */
No, this is not really acceptable for mainline... Please revisit now ;) Thanks. -- Dmitry