Re: [RFC v2 PATCH 1/7] matrix_keypad: Increase the max limit of rows and columns

Hi Dmitry,

On 2/9/2011 1:32 PM, Eric Miao wrote:

On Tue, Feb 1, 2011 at 9:47 PM, Anirudh Ghayal [off-list ref] wrote:

quoted

From: Trilok Soni <redacted>

Some keyboard controller have support for more than
16 columns and rows. Moving this value to 32.

Cc: Eric Miao <redacted>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Trilok Soni <redacted>

This looks good to me, as long as the bits don't exceed 256, which
is used in the #KEY() macro. So far, 32 looks to be a sane number
to me, unless we have further requirement to get this larger.

Acked-by: Eric Miao <redacted>

Are you going to pick up this patch only from the series you want us to get
it submitted it separately?

---Trilok Soni

-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.