Re: [RFC v2 PATCH 1/7] matrix_keypad: Increase the max limit of rows and columns
From: Eric Miao <hidden>
Date: 2011-02-09 08:02:50
Also in:
linux-arm-msm, lkml
On Tue, Feb 1, 2011 at 9:47 PM, Anirudh Ghayal [off-list ref] wrote:
From: Trilok Soni <redacted> Some keyboard controller have support for more than 16 columns and rows. Moving this value to 32. Cc: Eric Miao <redacted> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Trilok Soni <redacted>
This looks good to me, as long as the bits don't exceed 256, which is used in the #KEY() macro. So far, 32 looks to be a sane number to me, unless we have further requirement to get this larger. Acked-by: Eric Miao <redacted>
quoted hunk ↗ jump to hunk
--- Changes from v1: Moved the max columns and rows to 32 include/linux/input/matrix_keypad.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)diff --git a/include/linux/input/matrix_keypad.h b/include/linux/input/matrix_keypad.h index 6974746..fe7c4b9 100644 --- a/include/linux/input/matrix_keypad.h +++ b/include/linux/input/matrix_keypad.h@@ -4,8 +4,8 @@#include <linux/types.h> #include <linux/input.h> -#define MATRIX_MAX_ROWS 16 -#define MATRIX_MAX_COLS 16 +#define MATRIX_MAX_ROWS 32 +#define MATRIX_MAX_COLS 32 #define KEY(row, col, val) ((((row) & (MATRIX_MAX_ROWS - 1)) << 24) |\ (((col) & (MATRIX_MAX_COLS - 1)) << 16) |\ -- 1.7.3.5
-- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html