Re: [PATCHv2] evdev: fix evdev_write return value on partial writes
From: Henrik Rydberg <hidden>
Date: 2011-01-27 12:25:52
Possibly related (same subject, not in this thread)
- 2011-02-04 · Re: [PATCHv2] evdev: fix evdev_write return value on partial writes · Henrik Rydberg <hidden>
- 2011-02-04 · Re: [PATCHv2] evdev: fix evdev_write return value on partial writes · Dmitry Torokhov <dmitry.torokhov@gmail.com>
- 2011-02-04 · Re: [PATCHv2] evdev: fix evdev_write return value on partial writes · Henrik Rydberg <hidden>
- 2011-02-04 · Re: [PATCHv2] evdev: fix evdev_write return value on partial writes · Peter Korsgaard <jacmet@sunsite.dk>
- 2011-02-04 · Re: [PATCHv2] evdev: fix evdev_write return value on partial writes · Henrik Rydberg <hidden>
On Thu, Jan 27, 2011 at 01:04:49PM +0100, Peter Korsgaard wrote:
quoted
quoted
quoted
quoted
quoted
"Henrik" == Henrik Rydberg [off-list ref] writes:Hi, Henrik> I won't argue against this case (with < 0) being frequent, but one Henrik> should really check "n < len" to be safe. Hopefully Dmitry has some Henrik> more input. No, the point is that write (and read) can consume less data than requested, without it being an error. Robust userspace code should adjust buffer address / size and redo the work until all data is transferred or an error occurs.
Shouldn't the error be on (!len || len % smallest_acceptable_chunk), then? Which makes me wonder about regressions - perhaps accumulating partial writes in evdev is more safe from that perspective. Thanks, Henrik