Re: [PATCH 2/2] hid-multitouch: introduce IrTouch Infrared USB device

On Fri, Jan 28, 2011 at 06:59:13PM +0100, Benjamin Tissoires wrote:

On Fri, Jan 28, 2011 at 18:21, Henrik Rydberg [off-list ref] wrote:

quoted

On Fri, Jan 28, 2011 at 05:04:40PM +0100, Benjamin Tissoires wrote:

quoted

The product id is the 42 inches one. I don't know if they have
other product id for the other size, or if it is a per-size product id.

Tested-by: Victor Zhuk <redacted>
Signed-off-by: Benjamin Tissoires <redacted>
---

The canonical patch description presents the reason for the change,
and what the patch does (not necessarily how).

It was just to keep trace of the kind of display it was. As Florian
told the 63" does not have the same PID but not also the same
protocol.
Otherwise, we can also change the name of the define, but I'm not sure
on the rule to apply here.

Oh, I meant the patch description simply needs to be a bit more
self-contained. Keeping special information as what you write is
great, it just needs to in addition tell things like: "The IrTouch
infrared panels currently lack kernel support", and/or "This patch
adds support for IrTouch 42''".

Thanks,
Henrik