On Mon, Aug 10, 2009 at 12:31 AM, Trilok Soni[off-list ref] wrote:

Hi Pavel,

On Sun, Aug 9, 2009 at 3:14 AM, Pavel Machek[off-list ref] wrote:

quoted

On Sat 2009-08-08 22:12:46, Trilok Soni wrote:

...

quoted

quoted

I don't see any importance of gpio_matrix.c when we already have
generic gpio matrix driver mainlined. I would suggest to remove those
bits from this patch. I have added linux-input ML.

Well, I'm trying for staging merge at this point. Reasons why
gpio_matrix is there are:

1) it is non-trivial to remove

2) it has some features mainline lacks

3) HTC Dream actually works with it

(and 4) I'd like to submit code as Arve wrote it, then transform/clean
it up in staging).

Of course, relevant features will need to be extracted from
gpio_matrix and merged at the right places, and that needs to happen
before move from staging/, but I'd like to have working keyboard in
the meantime.

gpio_matrix in mainline should work with HTC G1 with few proper
platform data and input name eventhough ghost key clearance code is
not yet in mainline driver.

It would also be missing the end-call and volume keys.

I know you want HTC dream to work through staging but I would prefer
that such drivers should be discussed and reviewed on
linux-input/linux-kernel ML and not just dumped in staging.

As I mentioned when the matrix keypad driver was posted, we moved away
from having separate matrix and gpio input drivers since the the
hardware we use mix both types in the same logical keyboard. I did not
see any discussion about alternative ways to do this.

The current version of our driver (though this code does not appear to
be included this path) also supports creating multiple input devices
from a single set of inputs. This is needed on several new devices
where the trackball button is in keypad matrix and it is needed if you
want to report the same keycode from multiple keys (e.g. dream
external menu key and menu key in main keyboard).

-- 
Arve Hjønnevåg
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html