Hi Pavel,

On Sun, Aug 9, 2009 at 3:14 AM, Pavel Machek[off-list ref] wrote:

On Sat 2009-08-08 22:12:46, Trilok Soni wrote:

quoted

Hi Pavel,

On Sat, Aug 8, 2009 at 6:33 PM, Pavel Machek[off-list ref] wrote:

quoted

From: Arve Hj?nnev?g <arve@android.com>

Support for input devices connected to GPIO pins. This adds support
for HTC Dream's keyboard and its trackball. Generic support already
exists for keyboard on GPIO, but this one is more advanced because it
can detect shadow key presses (and actually works with Dream :-).

(It also contains Kconfig/Makefile changes, including some that were
missing from previous commit. Sorry.)

I don't see any importance of gpio_matrix.c when we already have
generic gpio matrix driver mainlined. I would suggest to remove those
bits from this patch. I have added linux-input ML.

Well, I'm trying for staging merge at this point. Reasons why
gpio_matrix is there are:

1) it is non-trivial to remove

2) it has some features mainline lacks

3) HTC Dream actually works with it

(and 4) I'd like to submit code as Arve wrote it, then transform/clean
it up in staging).

Of course, relevant features will need to be extracted from
gpio_matrix and merged at the right places, and that needs to happen
before move from staging/, but I'd like to have working keyboard in
the meantime.

gpio_matrix in mainline should work with HTC G1 with few proper
platform data and input name eventhough ghost key clearance code is
not yet in mainline driver.

I know you want HTC dream to work through staging but I would prefer
that such drivers should be discussed and reviewed on
linux-input/linux-kernel ML and not just dumped in staging.

-- 
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni