RE: [PATCH] Input: rotary_encoder cleanup
From: H Hartley Sweeten <hidden>
Date: 2009-07-07 18:32:45
On Wednesday, July 01, 2009 11:50 AM, Daniel Mack wrote:
On Wed, Jul 01, 2009 at 02:45:58PM -0400, H Hartley Sweeten wrote:quoted
quoted
Hmm, and then report them all via the very same input device? Or register one for each encoder? The latter could easily be done by registering multiple platform_devices with different platform_data, right?I suppose each encoder could be registered individually. Then each would report as a unique input device. This should work with the driver as it is now. Then drawback is if there are a number of encoders and a userspace app is opening all of them and doing a EVIOCGRAB it makes the app a bit messy. I was thinking more or passing an array of encoders to the driver and then having it report all of them as one input device. That ends up being a lot cleaner.I'd be fine with such a change. Just curious: how many encoders do you have on your board?
I haven't had a chance to figure out a way to pass the array of encoders yet. But, to answer your question, I have a couple different control panels with 2, 3, or 4 rotary encoders on them. To go beyond 4 I think I will need to work out a patch that only requires 1 interrupt line for each encoder. My platform has 24 gpio's that can generate interrupts but I am using a number of them for other purposes. Regards, Hartley