Thread (12 messages) 12 messages, 3 authors, 2009-07-09

RE: [PATCH] Input: rotary_encoder cleanup

From: H Hartley Sweeten <hidden>
Date: 2009-06-30 15:56:38

On Monday, June 29, 2009 7:32 PM, Dmitry Torokhov wrote:
On Tue, Jun 23, 2009 at 06:21:26PM +0200, Daniel Mack wrote:
quoted
On Sat, Jun 20, 2009 at 06:15:51PM -0400, H Hartley Sweeten wrote:
quoted
There is no need to carry the two irq numbers in the allocated memory.
They are only needed for the free_irq() calls during the remove.  Since
the driver is already carrying the platform_data we can just call
gpio_to_irq() to get the irq number.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Acked-by: Daniel Mack <redacted>
Do we know how many encoders we need to have in the system to start
seeing the benefits (given that all these conversions increase text
size)?
Hmm.. Didn't think about that. How do you determine the text size?

I am trying to work out a clean way to pass an array of encoders from
the platform init file so that multiple devices can be handled by the
driver.  That was what prompted the change.

Regards,
Hartley
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help