Hi Marek,

On Tue, Jul 14, 2009 at 2:37 PM, Marek
Szyprowski[off-list ref] wrote:

Hello,

On Tuesday, July 14, 2009 10:25 AM, Dmitry Torokhov wrote:

quoted

On Tue, Jul 14, 2009 at 08:28:05AM +0200, Marek Szyprowski wrote:

quoted

Hello,
On Tuesday, July 14, 2009 5:10 AM, Kim Kyuwon wrote:

quoted

Dmitry Torokhov wrote:

quoted

On Mon, Jul 13, 2009 at 02:22:10PM +0530, Trilok Soni wrote:

quoted

I don't see this driver picked up yet in your -next branch. We should
target this driver to be mainlined in next merge window. This is very
important driver for some of the embedded systems, including palm pre
:)

I was wondering if somebody could test the patch below and if it still
works then I will apply to the next branch. Thanks!

Dear Marek,

Because I don't have the NCP board(which includes the max7359 keypad)
now, I can't test this patch. Marek, could you please test this patch?

I would like to, but I could not find the base version to which I can apply
that patch. I've tried v2 version posted in '[PATCH] Input: add MAX7359 key
switch controller driver, v2' mail from Sat 2009-05-09 04:10 with 2 patches
posted in replies to that main, but the latest patch still fails to apply.

Could someone send me a complete patch, so I can do a test?

Sending everything as attachments, maybe that will help...

Ok. I've did the tests.

MAX7359 keypad driver works after your patch, but reports much more events than
the previous version. In this test I pressed quickly the first button on the
keypad.

Old version:
NCP:~# hexdump /dev/input/event0
0000000 0037 0000 e733 000b 0001 00e7 0001 0000
0000010 0037 0000 e748 000b 0000 0000 0000 0000
0000020 0037 0000 94e2 000d 0001 00e7 0000 0000
0000030 0037 0000 94f3 000d 0000 0000 0000 0000

Please use evtest instead. It will give better output atleast.

-- 
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni