Re: [PATCH] Input: add MAX7359 key switch controller driver, v2
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2009-05-11 03:12:27
Also in:
lkml
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2009-05-11 03:12:27
Also in:
lkml
On Mon, May 11, 2009 at 11:34:54AM +0900, Kim Kyuwon wrote:
Hi Trilok, On Sun, May 10, 2009 at 2:27 AM, Trilok Soni [off-list ref] wrote:quoted
Hi Kim, On Sat, May 9, 2009 at 7:39 AM, Kim Kyuwon [off-list ref] wrote:quoted
The Maxim MAX7359 is a I2C interfaced key switch controller which provides microprocessors with management of up to 64 key switches. This patch adds support for the MAX7359 key switch controller. Signed-off-by: Kim Kyuwon <redacted>Thanks for implementing review comments. Please add Reviewed-by: Trilok Soni <redacted>Sorry, I didn't know I should put the "Reviewed-by" in the reviewed patch.(I'm still kernelnewbie :) )
You are not supposed to add it until somebody explicitely asks you to do that, same with Acked-by... The reason is that these tags constitute certain endorsement of the patch and while one person may review the patch he/she may not yet feel that review process is complete. Hope this makes some sense...
If possible, I want Dmitry to add "Reviewed-by" when he sends this driver to mainline, or I will send new patch again.
I have it added to my copy. -- Dmitry