Thread (96 messages) 96 messages, 12 authors, 2009-07-22

Re: [PATCH 2/2] mfd: twl4030: add twl4030-pwrbutton as our child

From: David Brownell <hidden>
Date: 2009-02-27 23:21:17
Also in: lkml

On Friday 27 February 2009, Andrew Morton wrote:
quoted
quoted
What has gone wrong here?
Not much I can see.  It's registering a platform_device,
but only if it could be used on this system.
Again, that all gets fixed if this is done the right way around.  Run
your probe function.  If the hardware is there, register with the core
and all the nodes appear.  If the hardware is not present: bale.
Right.  If there's no button hooked up to its "power button"
signal, don't register that "twl4030-pwrbutton" node.

The design of the whole subsystem appears to be upside down :(
You seem to be missing something.  Is it only the lack of that
tweak Felipe sent?

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help