Re: [PATCH 2/2] ati_remote2: Add autosuspend support

On Wed, Jun 04, 2008 at 10:32:57AM +0200, Oliver Neukum wrote:

Am Mittwoch 04 Juni 2008 10:20:21 schrieb Ville Syrj?l?:

quoted

On Tue, Jun 03, 2008 at 10:11:09PM +0200, Oliver Neukum wrote:

quoted

Am Dienstag 03 Juni 2008 20:45:47 schrieb Ville Syrjala:

quoted

+
+???????mutex_lock(&ati_remote2_mutex);

Too late. You can race with disconnect()

Hmm. Do you mean open() vs. disconnect()? Doesn't the input_dev's locking
take care of that? ati_remote2_mutex is there just to make ar2->flags
handling and urb submitting/killing atomic, it didn't even exist before
this autosuspend patch. Or perhaps I'm missing something...

Hm. Anybody on the list an expert on locking in the input layer?

Input core only protects open() and close(); connect() and
disconnect() belong to respective bus's implementation the device is
sitting on and input core has no authority over it.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html