Thread (15 messages) 15 messages, 3 authors, 2008-06-09

Re: RESEND: [PATCH 3/3] Misc: Add HP WMI laptop extras driver

From: Andrew Morton <akpm@linux-foundation.org>
Date: 2008-06-02 23:30:56
Also in: linux-acpi, lkml

On Thu, 29 May 2008 09:23:56 +0100
Matthew Garrett [off-list ref] wrote:
This driver adds support for reading and configuring certain information 
on modern HP laptops with WMI BIOS interfaces. It supports enabling and 
disabling the ambient light sensor, querying attached displays and hard 
drive temperature, sending events on docking and querying the state of 
the dock and toggling the state of the wifi, bluetooth and wwan hardware 
via rfkill. It also makes the little "(i)" button work on machines that 
send that via WMI rather than via the keyboard controller.
I should upgrade everyone to checkpatch-0.19...

WARNING: consider using strict_strtoul in preference to simple_strtoul
#300: FILE: drivers/misc/hp-wmi.c:244:
+       u32 tmp = simple_strtoul(buf, NULL, 10);

The reason for this is that simple_strtoul(() will treat "42foo" as
valid input (ie: 42).  Whereas strict_strtoul() will report an error,
which is neater of us.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help