On Wed, May 28, 2008 at 10:42:00PM -0700, Andrew Morton wrote:

On Wed, 28 May 2008 14:34:25 +0100 Matthew Garrett [off-list ref] wrote:

quoted

--- /dev/null
+++ b/drivers/misc/hp-wmi.c

I see no Kconfig or Makefile updates.

Oops. Will resend.

quoted

+static struct key_entry hp_wmi_keymap[] = {
+	{KE_SW, 0x01, SW_DOCK},
+	{KE_KEY, 0x02, KEY_BRIGHTNESSUP},
+	{KE_KEY, 0x03, KEY_BRIGHTNESSDOWN},
+	{KE_KEY, 0x04, KEY_HELP},
+	{KE_END, 0}
+};

Could be made const.  hp_wmi_input_setup() already honours that,
others will need tweaks.

Not if we want to be able to set the keymap, surely?
-- 
Matthew Garrett | mjg59@srcf.ucam.org